Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: skeleton loader for article cards #309

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

patricio0312rev
Copy link
Contributor

[articles] skeleton loading cards dark mode

Summary

  • Skeleton loader has been updated for the different variants for article cards, in both light and dark mode.
image image
  • As an extra, colors for the dark mode in the count in the header for the articles count has been fixed.
image

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev marked this pull request as ready for review October 27, 2023 17:13
@ItsANameToo ItsANameToo added this to the 0.10.0 milestone Oct 30, 2023
@ItsANameToo ItsANameToo changed the title feat: skeleton loader for article cards refactor: skeleton loader for article cards Oct 30, 2023
@ItsANameToo ItsANameToo merged commit 8752e79 into feat/articles Oct 30, 2023
14 checks passed
@ItsANameToo ItsANameToo deleted the feat/dark-mode-for-article-cards-skeleton branch October 30, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants